linux-kernel - Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190517194405.GA28795@agluck-desk>
Date:   Fri, 17 May 2019 12:44:05 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     "Ghannam, Yazen" <Yazen.Ghannam@....com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in
 hardware

On Fri, May 17, 2019 at 09:34:31PM +0200, Borislav Petkov wrote:
> On Fri, May 17, 2019 at 11:06:07AM -0700, Luck, Tony wrote:
> > and thus end up with that extra level on indent for the rest
> > of the function.
> 
> Ok:
> 
> @@ -1569,7 +1575,13 @@ static void __mcheck_cpu_init_clear_banks(void)
>  
>  		if (!b->init)
>  			continue;
> +
> +		/* Check if any bits are implemented in h/w */
>  		wrmsrl(msr_ops.ctl(i), b->ctl);
> +		rdmsrl(msr_ops.ctl(i), msrval);
> +
> +		b->init = !!msrval;
> +
>  		wrmsrl(msr_ops.status(i), 0);
>  	}

Much neater :-)

Acked-by: Tony Luck <tony.luck@...el.com>