[<prev] [next>] [day] [month] [year] [list]
Message-ID: <tip-9a9hyuum8c0oggg86xd3sxc5@git.kernel.org>
Date: Sat, 18 May 2019 01:53:13 -0700
From: tip-bot for Arnaldo Carvalho de Melo <tipbot@...or.com>
To: linux-tip-commits@...r.kernel.org
Cc: eranian@...gle.com, adrian.hunter@...el.com, jolsa@...nel.org,
kan.liang@...ux.intel.com, alexander.shishkin@...ux.intel.com,
tglx@...utronix.de, ak@...ux.intel.com, hpa@...or.com,
peterz@...radead.org, linux-kernel@...r.kernel.org,
namhyung@...nel.org, acme@...hat.com, mingo@...nel.org
Subject: [tip:perf/core] perf parse-regs: Improve error output when faced
with unknown register name
Commit-ID: 4c1cf20334ae6e390e1ea787ef76c40a161370d1
Gitweb: https://git.kernel.org/tip/4c1cf20334ae6e390e1ea787ef76c40a161370d1
Author: Arnaldo Carvalho de Melo <acme@...hat.com>
AuthorDate: Mon, 13 May 2019 14:28:32 -0400
Committer: Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Wed, 15 May 2019 16:36:47 -0300
perf parse-regs: Improve error output when faced with unknown register name
Add quotes around the register name and suggest using 'perf record -I?'
to get the list of available registers.
Before:
# perf record -Idi,xmm20,xmm1
Warning:
unknown register xmm20, check man page
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-I, --intr-regs[=<any register>]
sample selected machine registers on interrupt, use -I ? to list register names
#
# perf record -Idi,xmm20,xmm1
Warning:
unknown register "xmm20", check man page or run "perf record -I?"
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-I, --intr-regs[=<any register>]
sample selected machine registers on interrupt, use -I ? to list register names
#
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Andi Kleen <ak@...ux.intel.com>
Cc: Jiri Olsa <jolsa@...nel.org>
Cc: Kan Liang <kan.liang@...ux.intel.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Stephane Eranian <eranian@...gle.com>
Link: https://lkml.kernel.org/n/tip-9a9hyuum8c0oggg86xd3sxc5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
tools/perf/util/parse-regs-options.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c
index e6599e290f46..9cb187a20fe2 100644
--- a/tools/perf/util/parse-regs-options.c
+++ b/tools/perf/util/parse-regs-options.c
@@ -48,8 +48,7 @@ parse_regs(const struct option *opt, const char *str, int unset)
break;
}
if (!r->name) {
- ui__warning("unknown register %s,"
- " check man page\n", s);
+ ui__warning("Unknown register \"%s\", check man page or run \"perf record -I?\"\n", s);
goto error;
}
Powered by blists - more mailing lists