linux-kernel - Re: [PATCH RFC] time: validate watchdog clocksource using second best candidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1905191753300.3019@nanos.tec.linutronix.de>
Date:   Sun, 19 May 2019 17:55:31 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
cc:     Stephen Boyd <sboyd@...nel.org>,
        John Stultz <john.stultz@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] time: validate watchdog clocksource using second
 best candidate

On Sat, 18 May 2019, Thomas Gleixner wrote:
> On Sat, 18 May 2019, Konstantin Khlebnikov wrote:
> > If there is no second clocksource my patch does noting:
> > watchdog_backup stays NULL and backup_consent always true.
> 
> That still does not justify the extra complexity for a few custom built
> systems.

Aside of that this leaves the HPET in a half broken state. HPET is not only
used as a clock event device it's also exposed by HPET device. So no, if we
figure out that HPET is broken on some platforms we have to blacklist and
disable it completely and not just duct tape the place which exposes the
wreckage.

Thanks,

	tglx