linux-kernel - Re: [PATCH] of_net: fix of_get_mac_address retval if compiled without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 May 2019 10:35:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ynezz@...e.cz
Cc:     robh+dt@...nel.org, frowand.list@...il.com, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com, mlindner@...vell.com,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of_net: fix of_get_mac_address retval if compiled
 without CONFIG_OF

From: Petr Štetiar <ynezz@...e.cz>
Date: Sun, 19 May 2019 14:18:44 +0200

> of_get_mac_address prior to commit d01f449c008a ("of_net: add NVMEM
> support to of_get_mac_address") could return only valid pointer or NULL,
> after this change it could return only valid pointer or ERR_PTR encoded
> error value, but I've forget to change the return value of
> of_get_mac_address in case where the kernel is compiled without
> CONFIG_OF, so I'm doing so now.
> 
> Cc: Mirko Lindner <mlindner@...vell.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address")
> Reported-by: Octavio Alvarez <octallk1@...arezp.org>
> Signed-off-by: Petr Štetiar <ynezz@...e.cz>

Applied, thanks.