linux-kernel - Re: [PATCH v3] kbuild: check uniqueness of module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 May 2019 10:04:37 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, Jessica Yu <jeyu@...nel.org>,
        Lucas De Marchi <lucas.demarchi@...el.com>,
        Michael Schmitz <schmitzmic@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Kees Cook <keescook@...omium.org>,
        Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
        Alexander Kapshuk <alexander.kapshuk@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kbuild: check uniqueness of module names

Hi Masahiro,

On Sat, 18 May 2019 01:07:15 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> 
> +++ b/scripts/modules-check.sh
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set -e
> +
> +# Check uniqueness of module names
> +check_same_name_modules()
> +{
> +	for m in $(sed 's:.*/::' modules.order modules.builtin | sort | uniq -d)
> +	do
> +		echo "warning: same basename if the following are built as modules:" >&2
> +		sed "/\/$m/!d;s:^kernel/:  :" modules.order modules.builtin >&2

(bringing out my bike shed paint brush :-))
this could be
	sed -n "/\/$m/s:^kernel/:  :p" ...

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped