linux-kernel - [PATCH 0/7] staging: vt6656: clean-up error path on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 May 2019 16:39:00 +0000
From:   Quentin Deslandes <quentin.deslandes@...ev.co.uk>
To:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
CC:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Quentin Deslandes <quentin.deslandes@...ev.co.uk>,
        Mukesh Ojha <mojha@...eaurora.org>,
        Ojaswin Mujoo <ojaswin25111998@...il.com>,
        Nishad Kamdar <nishadkamdar@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH 0/7] staging: vt6656: clean-up error path on init

This patchset aims to cleanup vt6656 driver's error path during the
initialization process.

During a call to vnt_start(), none of the functions called would return
a meaningful error code nor handle the one returned from the functions
they call themselves.

The first patch of the series fixes a potential NULL pointer dereferencing.
All the other patches update function's error management workflow and prototype
when needed.

More functions would need to be updated, but focusing on initialization
process force to change only a reasonable amount of code.

Thank you,
Quentin

Quentin Deslandes (7):
  staging: vt6656: fix potential NULL pointer dereference
  staging: vt6656: clean function's error path in usbpipe.c
  staging: vt6656: avoid discarding called function's return code
  staging: vt6656: clean error path for firmware management
  staging: vt6656: use meaningful error code during buffer allocation
  staging: vt6656: clean-up registers initialization error path
  staging: vt6656: manage error path during device initialization

 drivers/staging/vt6656/baseband.c | 130 +++++++++++------
 drivers/staging/vt6656/baseband.h |   8 +-
 drivers/staging/vt6656/card.c     |  20 ++-
 drivers/staging/vt6656/firmware.c |  91 ++++++------
 drivers/staging/vt6656/int.c      |   8 +-
 drivers/staging/vt6656/int.h      |   2 +-
 drivers/staging/vt6656/mac.c      |  19 ++-
 drivers/staging/vt6656/mac.h      |   6 +-
 drivers/staging/vt6656/main_usb.c | 230 ++++++++++++++++++------------
 drivers/staging/vt6656/rf.c       |  38 +++--
 drivers/staging/vt6656/rf.h       |   2 +-
 drivers/staging/vt6656/usbpipe.c  | 115 ++++++++-------
 drivers/staging/vt6656/usbpipe.h  |   4 +-
 13 files changed, 400 insertions(+), 273 deletions(-)

-- 
2.17.1