linux-kernel - Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190520173541.GA30280@infradead.org>
Date:   Mon, 20 May 2019 10:35:41 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Alex Elder <elder@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, David Miller <davem@...emloft.net>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        syadagir@...eaurora.org, mjavid@...eaurora.org,
        evgreen@...omium.org, Ben Chan <benchan@...gle.com>,
        Eric Caruso <ejcaruso@...gle.com>, abhishek.esse@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

On Mon, May 20, 2019 at 09:55:42AM -0500, Alex Elder wrote:
> On 5/20/19 9:50 AM, Arnd Bergmann wrote:
> > Ok, that sounds reasonable, yes. I'm not sure if
> > dma_alloc_coherent() guarantees zero-initialization
> > though, so if that is required, you may have to
> > add a memset().
> I had dma_zalloc_coherent() originally but I think
> Christoph Hellwig posted something recently that
> removed that function, because dma_alloc_coherent()
> always zeroes the underlying memory.
> 
> +Christoph, who might be able to explain or confirm

dma_alloc_coherent always zeroes the returned memory, which
is why dma_zalloc_coherent has been removed.