linux-kernel - Re: [PATCH 1/2] eeprom: at24: use devm_i2c_new_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJW=T_hZAkyhsE+Wi7qhJBE2bviNfaGCJJta0s8g85+9Pg@mail.gmail.com>
Date:   Mon, 20 May 2019 08:14:23 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] eeprom: at24: use devm_i2c_new_dummy_device()

niedz., 19 maj 2019 o 22:52 Wolfram Sang <wsa@...-dreams.de> napisał(a):
>
>
> > Now that it's upstream, use the resource managed version
> > of i2c_new_dummy().
>
> That was fast :)
>
> > -     dummy_client = i2c_new_dummy(base_client->adapter,
> > -                                  base_client->addr + index);
> > +     dummy_client = devm_i2c_new_dummy_device(dev, base_client->adapter,
> > +                                              base_client->addr + index);
> >       if (!dummy_client) {
>
> Oh well, the confusion starts already :/ devm_i2c_new_dummy_device()
> returns an ERR_PTR.
>

Ugh, sorry for that, especially since I followed the discussion on
that series. :(

I should not be sending out patches late on Sundays I guess.

Bart