linux-kernel - Re: [PATCH] staging: fieldbus: solve warning incorrect type dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiUCedv6oqTPOS+eFwnQJajor3hwKjxeNRcKq031giZeXg@mail.gmail.com>
Date:   Mon, 20 May 2019 15:39:46 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Oscar Gomez Fuente <oscargomezf@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

On Mon, May 20, 2019 at 2:35 PM Sven Van Asbroeck <thesven73@...il.com> wrote:
>
> Hi Oscar, thank you for your contribution! I have a question, see inline.
>
> On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> <oscargomezf@...il.com> wrote:
> >
> > These changes solve a warning realated to an incorrect type inilizer in the function
> > fieldbus_poll.
> >

This warning was generated by sparse, right?

$ make C=2 drivers/staging/fieldbus/
<snip>
  CHECK   drivers/staging/fieldbus/dev_core.c
drivers/staging/fieldbus/dev_core.c:232:27: warning: incorrect type in
initializer (different base types)
drivers/staging/fieldbus/dev_core.c:232:27:    expected restricted
__poll_t ( *poll )( ... )
drivers/staging/fieldbus/dev_core.c:232:27:    got unsigned int (
*<noident> )( ... )
<snip>

I will test your patch on actual h/w, probably tomorrow.
I don't expect to see any problems.

Sven