linux-kernel - Re: [BUG v5.2-rc1] ARM build broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201905201324.1259BAB119@keescook>
Date:   Mon, 20 May 2019 13:25:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [BUG v5.2-rc1] ARM build broken

On Mon, May 20, 2019 at 09:35:45PM +0200, H. Nikolaus Schaller wrote:
> 
> > Am 20.05.2019 um 20:53 schrieb Kees Cook <keescook@...omium.org>:
> > 
> > 
> >> Build error:
> >> 
> >> HOSTCXX -fPIC scripts/gcc-plugins/arm_ssp_per_task_plugin.o - due to: scripts/gcc-plugins/gcc-common.h
> >> In file included from scripts/gcc-plugins/arm_ssp_per_task_plugin.c:3:0:
> >> scripts/gcc-plugins/gcc-common.h:153:0: warning: "__unused" redefined
> >> #define __unused __attribute__((__unused__))
> >> ^
> > 
> > Does the following patch fix your build? (I assume that line is just a
> > warning, but if not...)
> > 
> > diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h
> > index 552d5efd7cb7..17f06079a712 100644
> > --- a/scripts/gcc-plugins/gcc-common.h
> > +++ b/scripts/gcc-plugins/gcc-common.h
> > @@ -150,8 +150,12 @@ void print_gimple_expr(FILE *, gimple, int, int);
> > void dump_gimple_stmt(pretty_printer *, gimple, int, int);
> > #endif
> > 
> > +#ifndef __unused
> > #define __unused __attribute__((__unused__))
> > +#endif
> > +#ifndef __visible
> > #define __visible __attribute__((visibility("default")))
> > +#endif
> > 
> > #define DECL_NAME_POINTER(node) IDENTIFIER_POINTER(DECL_NAME(node))
> > #define DECL_NAME_LENGTH(node) IDENTIFIER_LENGTH(DECL_NAME(node))
> 
> Yes, fixes this issue.

Ah, good! Okay, then the rest of the build errors were from not
finishing to build the plugin correctly. Thanks for debugging this; I'll
get the fix sent to Linus. :)

-- 
Kees Cook