lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 20 May 2019 10:07:32 +0800
From:   kbuild test robot <>
To:     Douglas Anderson <>
Cc:, Minas Harutyunyan <>,
        Felipe Balbi <>,,
        Alan Stern <>,
        Artur Petrosyan <>,,,
        William Wu <>,, Stefan Wahren <>,
        Randy Li <>,,,,
        Amelie Delaunay <>,,,
        Elaine Zhang <>,
        Douglas Anderson <>,
        Greg Kroah-Hartman <>,
Subject: Re: [REPOST PATCH v2 2/3] USB: dwc2: Don't turn off the usbphy in
 suspend if wakeup is enabled

Hi Douglas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.2-rc1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

base: next
config: x86_64-randconfig-h0-05191510 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <>

All errors (new ones prefixed by >>):

   ld: drivers/usb/dwc2/platform.o: in function `dwc2_can_poweroff_phy':
>> drivers/usb/dwc2/platform.c:545: undefined reference to `usb_wakeup_enabled_descendants'

vim +545 drivers/usb/dwc2/platform.c

   530	static bool __maybe_unused dwc2_can_poweroff_phy(struct dwc2_hsotg *dwc2)
   531	{
   532		struct usb_device *root_hub = dwc2_hsotg_to_hcd(dwc2)->self.root_hub;
   534		if (!dwc2->ll_hw_enabled)
   535			return false;
   537		/* If the controller isn't allowed to wakeup then we can power off. */
   538		if (!device_may_wakeup(dwc2->dev))
   539			return true;
   541		/*
   542		 * We don't want to power off the PHY if something under the
   543		 * root hub has wakeup enabled.
   544		 */
 > 545		if (usb_wakeup_enabled_descendants(root_hub))
   546			return false;
   548		/* No reason to keep the PHY powered, so allow poweroff */
   549		return true;
   550	}

0-DAY kernel test infrastructure                Open Source Technology Center                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30199 bytes)

Powered by blists - more mailing lists