linux-kernel - Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJiuCceEL9xH45P6Gj99YTir_1tkyraf5HefDNfm9p+UtdLs8w@mail.gmail.com>
Date:   Mon, 20 May 2019 10:21:40 +0200
From:   Clément Péron <peron.clem@...il.com>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chen-Yu Tsai <wens@...e.org>, linux-watchdog@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node

Hi,

On Mon, 20 May 2019 at 09:36, Maxime Ripard <maxime.ripard@...tlin.com> wrote:
>
> On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote:
> > Allwinner H6 has a watchog node which seems broken
> > on some boards.
> >
> > Test has been performed on several boards.
> >
> > Chen-Yu Tsai boards:
> > Pine H64 - H6448BA 7782 => OK
> > OrangePi Lite 2 - H8068BA 61C2 => KO
> >
> > Martin Ayotte boards:
> > Pine H64 - H8069BA 6892 => OK
> > OrangePi 3 - HA047BA 69W2 => KO
> > OrangePi One Plus - H7310BA 6842 => KO
> > OrangePi Lite2 - H6448BA 6662 => KO
> >
> > Clément Péron board:
> > Beelink GS1 - H7309BA 6842 => KO
> >
> > As it seems not fixable for now, declare the node
> > but leave it disable with a comment.
> >
> > Signed-off-by: Clément Péron <peron.clem@...il.com>
>
> If it doesn't work most boards, then why do we need to merge that
> patch in the first place?

My personnal opinion, is that having the IP declared and disabled with
a comment saying "it's broken on some boards" in the device-tree is
better than not having at all.

This will explicit say "the IP exist but don't use it!".
Maybe some people with a functionnal board would like to explicitly
use it on their dts.

Again just my personnal opinion,
Thanks for the review,
Clément

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com