linux-kernel - Re: [PATCH] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190520085539.GD19183@kroah.com>
Date:   Mon, 20 May 2019 10:55:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>
Cc:     Emanuel Bennici <benniciemanuel78@...il.com>,
        Vatsala Narang <vatsalanarang@...il.com>,
        Nishka Dasgupta <nishka.dasgupta@...oo.com>,
        Young Xiao <YangX92@...mail.com>,
        Aymen Qader <qader.aymen@...il.com>,
        Henriette Hofmeier <passt@...ofmeier.de>,
        Hardik Singh Rathore <hardiksingh.k@...il.com>,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        Michael Straube <straube.linux@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: rtw_mlme_ext: fix warning
 Unneeded variable: "ret"

On Sun, May 19, 2019 at 10:42:27PM +0530, Hariprasad Kelam wrote:
> This patch fixes below warnings reported by coccicheck
> 
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1888:14-17: Unneeded
> variable: "ret". Return "_FAIL" on line 1920
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:466:5-8: Unneeded
> variable: "res". Return "_SUCCESS" on line 494
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index d110d45..6a2eb66 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -463,7 +463,6 @@ static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, RT_CHANNEL_
>  
>  int	init_mlme_ext_priv(struct adapter *padapter)
>  {
> -	int	res = _SUCCESS;
>  	struct registry_priv *pregistrypriv = &padapter->registrypriv;
>  	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
>  	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
> @@ -491,7 +490,7 @@ int	init_mlme_ext_priv(struct adapter *padapter)
>  	pmlmeext->fixed_chan = 0xFF;
>  #endif
>  
> -	return res;
> +	return _SUCCESS;

If it can never fail, it should not be returning a value :(