linux-kernel - Re: [Patch v2] staging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190520085709.GE19183@kroah.com>
Date:   Mon, 20 May 2019 10:57:09 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>
Cc:     Payal Kshirsagar <payal.s.kshirsagar.98@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v2] staging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig:
 Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"

On Sun, May 19, 2019 at 10:57:24PM +0530, Hariprasad Kelam wrote:
> This patch fixes below warnings reported by coccicheck
> 
> drivers/staging/rtl8723bs/hal/odm_HWConfig.c:501:4-10: Unneeded
> variable: "result". Return "HAL_STATUS_SUCCESS" on line 526
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> -----
> Changes in v2:
>   - fixed typo in commit message
> ---
> 
> ---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index d802a1f..4711c65 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -498,8 +498,6 @@ HAL_STATUS ODM_ConfigBBWithHeaderFile(
>  
>  HAL_STATUS ODM_ConfigMACWithHeaderFile(PDM_ODM_T pDM_Odm)
>  {
> -	u8 result = HAL_STATUS_SUCCESS;
> -
>  	ODM_RT_TRACE(
>  		pDM_Odm,
>  		ODM_COMP_INIT,
> @@ -523,5 +521,5 @@ HAL_STATUS ODM_ConfigMACWithHeaderFile(PDM_ODM_T pDM_Odm)
>  
>  	READ_AND_CONFIG(8723B, _MAC_REG);
>  
> -	return result;
> +	return HAL_STATUS_SUCCESS;
>  }

This whole function should really be reduced to just one line (the trace
stuff is not needed), and as this can not fail, it should not be
returning a value.

And if it can be one line, then why is it a function at all?  It's only
called in one place.

thanks,

greg k-h