linux-kernel - Re: [PATCH v2 2/3] drm: shmem: Add drm_gem_shmem_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 May 2019 10:21:09 +0100
From:   Steven Price <steven.price@....com>
To:     Rob Herring <robh@...nel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        David Airlie <airlied@...ux.ie>,
        Inki Dae <inki.dae@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Sean Paul <sean@...rly.run>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] drm: shmem: Add drm_gem_shmem_map_offset() wrapper

On 16/05/2019 21:26, Daniel Vetter wrote:
> On Thu, May 16, 2019 at 03:14:46PM +0100, Steven Price wrote:
>> Provide a wrapper for drm_gem_map_offset() for clients of shmem. This
>> wrapper provides the correct semantics for the drm_gem_shmem_mmap()
>> callback.
>>
>> Signed-off-by: Steven Price <steven.price@....com>
>> ---
>>  drivers/gpu/drm/drm_gem_shmem_helper.c | 20 ++++++++++++++++++++
>>  include/drm/drm_gem_shmem_helper.h     |  2 ++
>>  2 files changed, 22 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
>> index 1ee208c2c85e..9dbebc4897d1 100644
>> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
>> @@ -400,6 +400,26 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev,
>>  }
>>  EXPORT_SYMBOL_GPL(drm_gem_shmem_dumb_create);
>>  
>> +/**
>> + * drm_gem_map_offset - return the fake mmap offset for a gem object
>> + * @file: drm file-private structure containing the gem object
>> + * @dev: corresponding drm_device
>> + * @handle: gem object handle
>> + * @offset: return location for the fake mmap offset
>> + *
>> + * This provides an offset suitable for user space to return to the
>> + * drm_gem_shmem_mmap() callback via an mmap() call.
>> + *
>> + * Returns:
>> + * 0 on success or a negative error code on failure.
>> + */
>> +int drm_gem_shmem_map_offset(struct drm_file *file, struct drm_device *dev,
>> +			     u32 handle, u64 *offset)
>> +{
>> +	return drm_gem_map_offset(file, dev, handle, offset);
>> +}
>> +EXPORT_SYMBOL_GPL(drm_gem_shmem_map_offset);
> 
> Not seeing the point of this mapper, since drm_gem_shmem_map_offset isn't
> speficic at all. It works for dumb, shmem, cma and private objects all
> equally well. I'd drop this and just directly call the underlying thing,
> no need to layer helpers.
> -Daniel

Ok, I'll drop it. I may have misunderstood, but I think Chris Wilson was
asking for it because shmem is the source of the particular requirements
of what can be mmap()d. But I think a helper can be added very easily if
anything changes, so this patch is probably premature.

I'll resend the series with this patch dropped.

Thanks,
Steve