linux-kernel - Re: [RESEND PATCH] staging: iio: ad7192: create of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+U=DspVbb7UoyThsEG5kqJ+9D2TJtUixF846TkQwFMdaqCpqw@mail.gmail.com>
Date:   Mon, 20 May 2019 13:22:02 +0300
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Bárbara Fernandes <barbara.fernandes@....br>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Stefan Popa <stefan.popa@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        LKML <linux-kernel@...r.kernel.org>,
        Wilson Sales <spoonm@...onm.org>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>
Subject: Re: [RESEND PATCH] staging: iio: ad7192: create of_device_id array

On Sun, May 19, 2019 at 8:53 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Sat, 18 May 2019 19:44:35 -0300
> Bárbara Fernandes <barbara.fernandes@....br> wrote:
>

I don't have anything else on top of what Jonathan added.

Acked-by: Alexandru Ardelean <alexandru.ardelean@...log.com>

CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.

> > Create list of compatible device ids to be matched with those stated in
> > the device tree.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@....br>
> > Signed-off-by: Wilson Sales <spoonm@...onm.org>
> > Co-developed by: Wilson Sales <spoonm@...onm.org>
> Hi Bárbara, Wilson,
>
> One minor issue inline about code ordering.
> Actual content is fine.
>
> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index 3d74da9d37e7..cc886f944dbf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> >       {"ad7195", ID_AD7195},
> >       {}
> >  };
> > +
> > +static const struct of_device_id ad7192_of_spi_match[] = {
> > +     { .compatible = "adi,ad7190" },
> > +     { .compatible = "adi,ad7192" },
> > +     { .compatible = "adi,ad7193" },
> > +     { .compatible = "adi,ad7195" },
> > +     {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> > +
> Please keep the declaration of the table alongside the relevant
> MODULE_DEVICE_TABLE.
>
> In short, better to have your additions after this next line.
> >  MODULE_DEVICE_TABLE(spi, ad7192_id);
> >
> >  static struct spi_driver ad7192_driver = {
> >       .driver = {
> >               .name   = "ad7192",
> > +             .of_match_table = ad7192_of_spi_match,
> >       },
> >       .probe          = ad7192_probe,
> >       .remove         = ad7192_remove,
>