linux-kernel - Re: [STABLE PATCH 1/2] crypto: ccree: zap entire sg on aead request unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190520120903.GB13524@kroah.com>
Date:   Mon, 20 May 2019 14:09:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, stable@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [STABLE PATCH 1/2] crypto: ccree: zap entire sg on aead request
 unmap

On Mon, May 20, 2019 at 02:50:23PM +0300, Gilad Ben-Yossef wrote:
> We were trying to be clever zapping out of the cache only the required
> length out of scatter list on AEAD request completion and getting it
> wrong.
> 
> As Knuth said: "when in douby, use brute force". Zap the whole length of
> the scatter list.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> ---
>  drivers/crypto/ccree/cc_buffer_mgr.c | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)

This does not apply on top of my latest 4.19 tree with the current
pending queue applied, nor does it apply to 5.1 or 5.0.

How about waiting a few days and resending after I do the next round of
stable updates, so you can rebase on top of them easier?

thanks,

greg k-h