linux-kernel - Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0ccc2f8-4d6a-bfa4-509d-e5d919efb3cd@ozlabs.ru>
Date:   Mon, 20 May 2019 14:48:56 +1000
From:   Alexey Kardashevskiy <aik@...abs.ru>
To:     Alex Williamson <alex.williamson@...hat.com>,
        "richard.peng@...o.com" <richard.peng@...o.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function



On 17/05/2019 00:48, Alex Williamson wrote:
> [Cc Alexey + kvm]
> 
> On Thu, 16 May 2019 20:38:26 +0800
> "richard.peng@...o.com" <richard.peng@...o.com> wrote:
> 
>> Use a vma helper function to simply code.
>>
>> Signed-off-by: Peng Hao <richard.peng@...o.com>
>> ---
>>  drivers/vfio/pci/vfio_pci_nvlink2.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
>> index 32f695ffe128..dc42aa0e47f6 100644
>> --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
>> +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
>> @@ -161,8 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev,
>>  
>>  	atomic_inc(&data->mm->mm_count);
>>  	ret = (int) mm_iommu_newdev(data->mm, data->useraddr,
>> -			(vma->vm_end - vma->vm_start) >> PAGE_SHIFT,
>> -			data->gpu_hpa, &data->mem);
>> +			vma_pages(vma), data->gpu_hpa, &data->mem);


I did not realize we have been having this mighty helper since 2005 :)

Reviewed-by: Alexey Kardashevskiy <aik@...abs.ru>



>>  
>>  	trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr,
>>  			vma->vm_end - vma->vm_start, ret);
>> -- 
>> 2.20.1

-- 
Alexey