linux-kernel - Re: [PATCH] staging: wilc1000: remove redundant masking of pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 18:43:27 +0000
From:   <Adham.Abozaeid@...rochip.com>
To:     <colin.king@...onical.com>, <Ajay.Kathat@...rochip.com>,
        <gregkh@...uxfoundation.org>, <linux-wireless@...r.kernel.org>,
        <devel@...verdev.osuosl.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: wilc1000: remove redundant masking of pkt_offset


On 5/21/19 6:17 AM, Colin King wrote:
> External E-Mail
>
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The masking update of pkg_offset is redundant as the updated
> value is never read and pkg_offset is re-assigned on the next
> iteration of the loop.  Clean this up by removing the redundant
> assignment.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Adham Abozaeid <adham.abozaeid@...rochip.com>


Thanks,

Adham

> ---
>  drivers/staging/wilc1000/wilc_wlan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index 95eaf8fdf4f2..dcd728557958 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -709,9 +709,6 @@ static void wilc_wlan_handle_rx_buff(struct wilc *wilc, u8 *buffer, int size)
>  			break;
>  
>  		if (pkt_offset & IS_MANAGMEMENT) {
> -			pkt_offset &= ~(IS_MANAGMEMENT |
> -					IS_MANAGMEMENT_CALLBACK |
> -					IS_MGMT_STATUS_SUCCES);
>  			buff_ptr += HOST_HDR_OFFSET;
>  			wilc_wfi_mgmt_rx(wilc, buff_ptr, pkt_len);
>  		} else {