linux-kernel - Re: [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190521185713.E24632173C@mail.kernel.org>
Date:   Tue, 21 May 2019 11:57:13 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Baolin Wang <baolin.wang@...aro.org>,
        Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:     linux-clk@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap_resource()

Quoting Baolin Wang (2019-05-20 23:38:03)
> On Tue, 21 May 2019 at 14:15, Chunyan Zhang <zhang.chunyan@...aro.org> wrote:
> >                                                &sprdclk_regmap_config);
> > -               if (IS_ERR_OR_NULL(regmap)) {
> > +               if (IS_ERR(regmap)) {
> 
> You did not mention this fix in your commit message, and it's better
> to move into one separate patch.
> 

Please resend with it split out.