linux-kernel - Re: [PATCH] arm: add missing include <linux/elf-randomize.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201905211323.7064F60D@keescook>
Date:   Tue, 21 May 2019 13:23:51 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Philippe Mazenauer <philippe.mazenauer@...look.de>
Cc:     Russell King <linux@...linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        "moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm: add missing include <linux/elf-randomize.h>

On Tue, May 21, 2019 at 03:54:36PM +0000, Philippe Mazenauer wrote:
> Include corresponding header file <linux/elf-randomize.h> for function
> arch_randomize_brk().
> 
> ../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
>  unsigned long arch_randomize_brk(struct mm_struct *mm)
>                ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@...look.de>

Acked-by: Kees Cook <keescook@...omium.org>

> ---
>  arch/arm/kernel/process.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 72cc0862a30e..73782012d403 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -23,6 +23,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/init.h>
>  #include <linux/elfcore.h>
> +#include <linux/elf-randomize.h>
>  #include <linux/pm.h>
>  #include <linux/tick.h>
>  #include <linux/utsname.h>
> -- 
> 2.17.1
> 

-- 
Kees Cook