linux-kernel - Re: [PATCH v3] kernel: fix typos and some coding style in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 13:40:38 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Colin Ian King <colin.king@...onical.com>
Cc:     mcgrof@...nel.org, linux-kernel@...r.kernel.org,
        Weitao Hou <houweitaoo@...il.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3] kernel: fix typos and some coding style in comments

On Tue, May 21, 2019 at 01:09:37PM +0800, Weitao Hou wrote:
> fix lenght to length
> 
> Signed-off-by: Weitao Hou <houweitaoo@...il.com>

Acked-by: Kees Cook <keescook@...omium.org>

I've aimed this at akpm... Colin, who normally takes your spelling
fix patches? (It looks like your split them up normally? That seems
silly here...)

-Kees

> ---
> Changes in v3:
> - fix all other same typos with git grep
> ---
>  .../devicetree/bindings/usb/s3c2410-usb.txt    |  2 +-
>  .../wireless/mediatek/mt76/mt76x02_usb_core.c  |  2 +-
>  kernel/sysctl.c                                | 18 +++++++++---------
>  sound/soc/qcom/qdsp6/q6asm.c                   |  2 +-
>  4 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> index e45b38ce2986..26c85afd0b53 100644
> --- a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt
> @@ -4,7 +4,7 @@ OHCI
>  
>  Required properties:
>   - compatible: should be "samsung,s3c2410-ohci" for USB host controller
> - - reg: address and lenght of the controller memory mapped region
> + - reg: address and length of the controller memory mapped region
>   - interrupts: interrupt number for the USB OHCI controller
>   - clocks: Should reference the bus and host clocks
>   - clock-names: Should contain two strings
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> index 6b89f7eab26c..e0f5e6202a27 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c
> @@ -53,7 +53,7 @@ int mt76x02u_skb_dma_info(struct sk_buff *skb, int port, u32 flags)
>  	pad = round_up(skb->len, 4) + 4 - skb->len;
>  
>  	/* First packet of a A-MSDU burst keeps track of the whole burst
> -	 * length, need to update lenght of it and the last packet.
> +	 * length, need to update length of it and the last packet.
>  	 */
>  	skb_walk_frags(skb, iter) {
>  		last = iter;
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 943c89178e3d..f78f725f225e 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -187,17 +187,17 @@ extern int no_unaligned_warning;
>   * enum sysctl_writes_mode - supported sysctl write modes
>   *
>   * @SYSCTL_WRITES_LEGACY: each write syscall must fully contain the sysctl value
> - * 	to be written, and multiple writes on the same sysctl file descriptor
> - * 	will rewrite the sysctl value, regardless of file position. No warning
> - * 	is issued when the initial position is not 0.
> + *	to be written, and multiple writes on the same sysctl file descriptor
> + *	will rewrite the sysctl value, regardless of file position. No warning
> + *	is issued when the initial position is not 0.
>   * @SYSCTL_WRITES_WARN: same as above but warn when the initial file position is
> - * 	not 0.
> + *	not 0.
>   * @SYSCTL_WRITES_STRICT: writes to numeric sysctl entries must always be at
> - * 	file position 0 and the value must be fully contained in the buffer
> - * 	sent to the write syscall. If dealing with strings respect the file
> - * 	position, but restrict this to the max length of the buffer, anything
> - * 	passed the max lenght will be ignored. Multiple writes will append
> - * 	to the buffer.
> + *	file position 0 and the value must be fully contained in the buffer
> + *	sent to the write syscall. If dealing with strings respect the file
> + *	position, but restrict this to the max length of the buffer, anything
> + *	passed the max length will be ignored. Multiple writes will append
> + *	to the buffer.
>   *
>   * These write modes control how current file position affects the behavior of
>   * updating sysctl values through the proc interface on each write.
> diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
> index 4f85cb19a309..e8141a33a55e 100644
> --- a/sound/soc/qcom/qdsp6/q6asm.c
> +++ b/sound/soc/qcom/qdsp6/q6asm.c
> @@ -1194,7 +1194,7 @@ EXPORT_SYMBOL_GPL(q6asm_open_read);
>   * q6asm_write_async() - non blocking write
>   *
>   * @ac: audio client pointer
> - * @len: lenght in bytes
> + * @len: length in bytes
>   * @msw_ts: timestamp msw
>   * @lsw_ts: timestamp lsw
>   * @wflags: flags associated with write
> -- 
> 2.18.0
> 

-- 
Kees Cook