linux-kernel - Re: [PATCH] dma: dw-axi-dmac: fix null dereference when pointer first is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190521045713.GQ15118@vkoul-mobl>
Date:   Tue, 21 May 2019 10:27:13 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Huang Shijie <sjhuang@...vatar.ai>, dmaengine@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: dw-axi-dmac: fix null dereference when pointer
 first is null

On 08-05-19, 23:33, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> In the unlikely event that axi_desc_get returns a null desc in the
> very first iteration of the while-loop the error exit path ends
> up calling axi_desc_put on a null pointer 'first' and this causes
> a null pointer dereference.  Fix this by adding a null check on
> pointer 'first' before calling axi_desc_put.

Applied, thanks

-- 
~Vinod