linux-kernel - Re: [PATCH] mm/failslab: By default, do not fail allocations with direct reclaim only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201905211524.RpQYbGWw%lkp@intel.com>
Date:   Tue, 21 May 2019 16:00:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nicolas Boichat <drinkcat@...omium.org>
Cc:     kbuild-all@...org, Andrew Morton <akpm@...ux-foundation.org>,
        David Rientjes <rientjes@...gle.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Michal Hocko <mhocko@...e.com>, Joe Perches <joe@...ches.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mm@...ck.org, Akinobu Mita <akinobu.mita@...il.com>,
        Pekka Enberg <penberg@...nel.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/failslab: By default, do not fail allocations with
 direct reclaim only

Hi Nicolas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc1 next-20190520]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Boichat/mm-failslab-By-default-do-not-fail-allocations-with-direct-reclaim-only/20190521-045221
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> mm/failslab.c:27:26: sparse: sparse: restricted gfp_t degrades to integer

vim +27 mm/failslab.c

    16	
    17	bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags)
    18	{
    19		/* No fault-injection for bootstrap cache */
    20		if (unlikely(s == kmem_cache))
    21			return false;
    22	
    23		if (gfpflags & __GFP_NOFAIL)
    24			return false;
    25	
    26		if (failslab.ignore_gfp_reclaim &&
  > 27				(gfpflags & ___GFP_DIRECT_RECLAIM))
    28			return false;
    29	
    30		if (failslab.cache_filter && !(s->flags & SLAB_FAILSLAB))
    31			return false;
    32	
    33		return should_fail(&failslab.attr, s->object_size);
    34	}
    35	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation