linux-kernel - Re: [PATCH v2] perf/x86/intel/ds: fix EVENT vs. UEVENT PEBS constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 10:26:11 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        ak@...ux.intel.com, kan.liang@...el.com, jolsa@...hat.com,
        vincent.weaver@...ne.edu
Subject: Re: [PATCH v2] perf/x86/intel/ds: fix EVENT vs. UEVENT PEBS
 constraints


* Stephane Eranian <eranian@...gle.com> wrote:

> This patch fixes an issue revealed by the following commit:
> Commit 6b89d4c1ae85 ("perf/x86/intel: Fix INTEL_FLAGS_EVENT_CONSTRAINT* masking")
> 
> That patch modified INTEL_FLAGS_EVENT_CONSTRAINT() to only look at the event code
> when matching a constraint. If code+umask were needed, then the
> INTEL_FLAGS_UEVENT_CONSTRAINT() macro was needed instead.
> This broke with some of the constraints for PEBS events.
> Several of them, including the one used for cycles:p, cycles:pp, cycles:ppp
> fell in that category and caused the event to be rejected in PEBS mode.
> In other words, on some platforms a cmdline such as:
> 
>   $ perf top -e cycles:pp
> 
>   would fail with EINVAL.
> 
> This patch fixes this issue by properly using INTEL_FLAGS_UEVENT_CONSTRAINT()
> when needed in the PEBS constraint tables.
> 
> In v2:
>   - add fixes for Core2, Nehalem, Silvermont, and Atom
> 
> Reported-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Stephane Eranian <eranian@...gle.com>
> ---
>  arch/x86/events/intel/ds.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Thanks Stephane for the quick fixes!

	Ingo