linux-kernel - Re: [ANNOUNCE] Git v2.22.0-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACsJy8AdhQH25NeDKKdSBctXcU=oyGcJ05XaNryj22GUQH5Btw@mail.gmail.com>
Date:   Tue, 21 May 2019 15:31:52 +0700
From:   Duy Nguyen <pclouds@...il.com>
To:     Ævar Arnfjörð Bjarmason <avarab@...il.com>
Cc:     Bryan Turner <bturner@...assian.com>,
        Junio C Hamano <gitster@...ox.com>,
        Git Users <git@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        git-packagers@...glegroups.com
Subject: Re: [ANNOUNCE] Git v2.22.0-rc1

On Tue, May 21, 2019 at 5:27 AM Ævar Arnfjörð Bjarmason
<avarab@...il.com> wrote:
>
>
> On Mon, May 20 2019, Bryan Turner wrote:
>
> > On Sun, May 19, 2019 at 10:00 AM Junio C Hamano <gitster@...ox.com> wrote:
> >>
> >>  * The diff machinery, one of the oldest parts of the system, which
> >>    long predates the parse-options API, uses fairly long and complex
> >>    handcrafted option parser.  This is being rewritten to use the
> >>    parse-options API.
> >
> > It looks like with these changes it's no longer possible to use "-U"
> > (or, I'd assume, "--unified") without adding an explicit number for
> > context lines.
> >
> > ...
>
> I don't know if argument-less -U was ever intended, but I think in light
> of what you're saying we should consider it a regression to fix before
> 2.22.0 is out. CC-ing Duy who wrote d473e2e0e8 ("diff.c: convert
> -U|--unified", 2019-01-27).

There should be no behavior change in this series. Period. I'm pretty
sure I misread the old opt_arg() code and this is the result.
--inter-hunk-context is also affected. I'm working on it.

> The bug there is that the old opt_arg() code would be torelant to empty
> values. I noticed a similar change the other day with the --abbrev
> option, but didn't think it was worth noting. Maybe it's a more general
> problem, in both cases we had a blindspot in our tests.

Hmm.. this one is different (at least it does not use opt_arg()). But
I'll double check.
-- 
Duy