linux-kernel - Re: [PATCH] btrfs: correct zstd workspace manager lock to use spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190521090103.GH3138@twin.jikos.cz>
Date:   Tue, 21 May 2019 11:01:03 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Dennis Zhou <dennis@...nel.org>
Cc:     David Sterba <dsterba@...e.com>,
        Josef Bacik <josef@...icpanda.com>, Chris Mason <clm@...com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, "Erhard F ." <erhard_f@...lbox.org>
Subject: Re: [PATCH] btrfs: correct zstd workspace manager lock to use
 spin_lock_bh()

On Fri, May 17, 2019 at 07:16:26PM -0400, Dennis Zhou wrote:
> The btrfs zstd workspace manager uses a background timer to reclaim
> not recently used workspaces. I dumbly call spin_lock() from this
> context which I should have caught with lockdep but.. This deadlock was
> reported in [1]. The fix is to switch the zstd wsm lock to use
> spin_lock_bh().
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=203517
> 
> Signed-off-by: Dennis Zhou <dennis@...nel.org>

Reviewed-by: David Sterba <dsterba@...e.com>

Added to 5.2-rc queue, thanks.