linux-kernel - Re: [PATCH v2] tty: serial: msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190521101131.GC13612@kroah.com>
Date:   Tue, 21 May 2019 12:11:31 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jorge Ramirez <jorge.ramirez-ortiz@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>, agross@...nel.org,
        david.brown@...aro.org, sboyd@...nel.org, jslaby@...e.com,
        keescook@...omium.org, anton@...msg.org, ccross@...roid.com,
        tony.luck@...el.com, linux-arm-msm@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty: serial: msm_serial: Fix XON/XOFF

On Mon, May 20, 2019 at 08:57:39PM +0200, Jorge Ramirez wrote:
> On 5/20/19 20:50, Bjorn Andersson wrote:
> > On Mon 20 May 11:38 PDT 2019, Jorge Ramirez-Ortiz wrote:
> > 
> >> When the tty layer requests the uart to throttle, the current code
> >> executing in msm_serial will trigger "Bad mode in Error Handler" and
> >> generate an invalid stack frame in pstore before rebooting (that is if
> >> pstore is indeed configured: otherwise the user shall just notice a
> >> reboot with no further information dumped to the console).
> >>
> >> This patch replaces the PIO byte accessor with the word accessor
> >> already used in PIO mode.
> >>
> >> Fixes: 68252424a7c7 ("tty: serial: msm: Support big-endian CPUs")
> >> Cc: stable@...r.kernel.org
> >> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > 
> > You missed Stephen's
> > 
> > Reviewed-by: Stephen Boyd <swboyd@...omium.org>
> 
> argh sorry Stephen. can the maintainer add it when it gets merged or
> shall I post V3?

I'll fix it up...