linux-kernel - Re: [PATCH v6 1/3] media: cec: expose HDMI connector to CEC dev mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 13:02:01 +0200
From:   Dariusz Marcinkiewicz <darekm@...gle.com>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     linux-media@...r.kernel.org, hans.verkuil@...co.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] media: cec: expose HDMI connector to CEC dev mapping

On Mon, May 20, 2019 at 12:25 PM Hans Verkuil <hverkuil@...all.nl> wrote:
>
> It's a bit unusual since it uses the Synopsys bridge, but not the Synopsys
> CEC driver (it has its own meson cec driver).
>
> The first thing I noticed is that I did not get any connector info.
> I think that the root cause of that is that you forgot that there are
> several drm drivers that call cec_notifier_get() instead of cec_notifier_get_conn().
>
> I think all those calls to cec_notifier_get() in drm drivers should be replaced
> by cec_notifier_get_conn() where the second argument is NULL, but the third argument
> should contain valid connector info.
>
> A quick grep gives me the following drivers that need work:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> drivers/gpu/drm/exynos/exynos_hdmi.c
> drivers/gpu/drm/i2c/tda998x_drv.c
> drivers/gpu/drm/sti/sti_hdmi.c
> drivers/gpu/drm/tegra/output.c
>
I am afraid that just replacing cec_notifier_get with
cec_notifier_get_conn won't necessarily make this information
available, as, e.g. looking at tegra, those would also require some
reshuffling of the code so that notifier is created once connector is
initialized. Btw. I've updated dw-hdmi.c and tda998x_drv.c to use
cec_notifier_get_conn, so at least those 2 will be covered.


> The second thing I noticed is that patch 2 gave me a new kernel warning, but
> I'll do some more testing for that and reply to patch 2/3 once I know more.
>
I hope this is fixed in v7.

Thank you for your testing and best regards!