lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 May 2019 21:49:38 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Andrew Donnellan <ajd@...ux.ibm.com>, Eric Piel <eric.piel@...mplin-utc.net>, Frank Haverkamp <haver@...ux.ibm.com>, Frederic Barrat <fbarrat@...ux.ibm.com>, Michał Mirosław <mirq-linux@...e.qmqm.pl>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> writes: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig behavior is the same > regardless of 'default n' being present or not: > > ... > One side effect of (and the main motivation for) this change is making > the following two definitions behave exactly the same: > > config FOO > bool > > config FOO > bool > default n > > With this change, neither of these will generate a > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> ... > Index: b/drivers/misc/ocxl/Kconfig > =================================================================== > --- a/drivers/misc/ocxl/Kconfig > +++ b/drivers/misc/ocxl/Kconfig > @@ -4,7 +4,6 @@ > > config OCXL_BASE > bool > - default n > select PPC_COPRO_BASE > > config OCXL Acked-by: Michael Ellerman <mpe@...erman.id.au> (ocxl) cheers
Powered by blists - more mailing lists