linux-kernel - Re: [PATCH v2] doc: kernel-parameters.txt: fix documentation of nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190521085627.0b36cd80@gandalf.local.home>
Date:   Tue, 21 May 2019 08:56:27 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        paulmck@...ux.ibm.com, josh@...htriplett.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, corbet@....net, tglx@...utronix.de,
        mingo@...nel.org, gregkh@...uxfoundation.org,
        keescook@...omium.org, srinivas.eeda@...cle.com
Subject: Re: [PATCH v2] doc: kernel-parameters.txt: fix documentation of
 nmi_watchdog parameter

On Tue, 21 May 2019 17:42:28 +0800
Zhenzhong Duan <zhenzhong.duan@...cle.com> wrote:

> On 2019/5/15 3:21, Steven Rostedt wrote:
> > On Sun, 12 May 2019 11:35:27 +0800
> > Zhenzhong Duan <zhenzhong.duan@...cle.com> wrote:
> >  
> >> The default behavior of hardlockup depends on the config of
> >> CONFIG_BOOTPARAM_HARDLOCKUP_PANIC.
> >>
> >> Fix the description of nmi_watchdog to make it clear.
> >>
> >> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
> >> Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> >> Cc: Steven Rostedt <rostedt@...dmis.org>  
> > Perhaps it should have been:
> >
> >   Suggested-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> >
> > As the wording is what I suggested ;-)  
> 
> Sure, I should have done that. Just not familiar with which one is better.
> 
> Not clear if I should send a v3 adding Suggested-by and Acked-by?

Yep, it's fine to add both:

Suggested-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> 
> Zhenzhong