linux-kernel - Re: [PATCH net v3] netfilter: nf_queue:fix reinject verdict handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190521140202.yjqjygtw3l36pi6h@salvia>
Date:   Tue, 21 May 2019 16:02:02 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jagdish Motwani <j.k.motwani@...il.com>
Cc:     netdev@...r.kernel.org,
        Jagdish Motwani <jagdish.motwani@...hos.com>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] netfilter: nf_queue:fix reinject verdict handling

On Mon, May 13, 2019 at 11:47:40PM +0530, Jagdish Motwani wrote:
> From: Jagdish Motwani <jagdish.motwani@...hos.com>
> 
> This patch fixes netfilter hook traversal when there are more than 1 hooks
> returning NF_QUEUE verdict. When the first queue reinjects the packet,
> 'nf_reinject' starts traversing hooks with a proper hook_index. However,
> if it again receives a NF_QUEUE verdict (by some other netfilter hook), it
> queues the packet with a wrong hook_index. So, when the second queue 
> reinjects the packet, it re-executes hooks in between.

Applied, thanks.