linux-kernel - Re: staging: Add rtl8723bs sdio wifi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 18:57:12 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Colin Ian King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: staging: Add rtl8723bs sdio wifi driver

Hi,

On 5/21/19 3:49 PM, Colin Ian King wrote:
> Hi,
> 
> static analysis with Coverity has detected an issues in the rtl8723bs
> wifi driver:
> 
> File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function
> rtw_dbg_port():
> 
> CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
> dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true.
> 
>          if ((extra_arg & 0x07) > 0x07)
>                  padapter->driver_ampdu_spacing = 0xFF;
>          else
>                  padapter->driver_ampdu_spacing = extra_arg;
> 
> 
> I'm not sure if the mask is (in)correct or the value it is being
> compared to 0x07 is (in)correct (or both!)

Hmm, after looking at the rest of the code, it is clear that valid
values for driver_ampdu_spacing or 0 - 7, otherwise it should
be set to 0xff which means use the driver default.

I will send a patch fixing this.

Regards,

Hans