linux-kernel - Re: [PATCH v2] signal: Adjust error codes according to restore_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190522221805.GA30062@chrisdown.name>
Date:   Wed, 22 May 2019 18:18:05 -0400
From:   Chris Down <chris@...isdown.name>
To:     deepa.kernel@...il.com
Cc:     akpm@...ux-foundation.org, arnd@...db.de, axboe@...nel.dk,
        dave@...olabs.net, dbueso@...e.de, e@...24.org, jbaron@...mai.com,
        linux-aio@...ck.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, oleg@...hat.com,
        omar.kilani@...il.com, stable@...r.kernel.org, tglx@...utronix.de,
        viro@...iv.linux.org.uk, linux-mm@...ck.org
Subject: Re: [PATCH v2] signal: Adjust error codes according to
 restore_user_sigmask()

+Cc: linux-mm, since this broke mmots tree and has been applied there

This patch is missing a definition for signal_detected in io_cqring_wait, which 
breaks the build.

diff --git fs/io_uring.c fs/io_uring.c
index b785c8d7efc4..b34311675d2d 100644
--- fs/io_uring.c
+++ fs/io_uring.c
@@ -2182,7 +2182,7 @@ static int io_cqring_wait(struct io_ring_ctx *ctx, int min_events,
 {
        struct io_cq_ring *ring = ctx->cq_ring;
        sigset_t ksigmask, sigsaved;
-       int ret;
+       int ret, signal_detected;
 
        if (io_cqring_events(ring) >= min_events)
                return 0;