linux-kernel - Re: [PATCH] docs: reorder memory-hotplug documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2cd2bbde-e929-d730-30f3-a9419072a788@redhat.com>
Date:   Wed, 22 May 2019 09:29:21 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     Mike Rapoport <rppt@...ux.ibm.com>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: reorder memory-hotplug documentation

On 21.05.19 18:11, Oscar Salvador wrote:
> On Tue, May 21, 2019 at 12:41:50PM +0200, David Hildenbrand wrote:
>>> +Future Work
>>> +===========
>>> +
>>> +  - allowing memory hot-add to ZONE_MOVABLE. maybe we need some switch like
>>> +    sysctl or new control file.
>>
>> ... that already works if I am not completely missing the point here
> 
> It does.
> 
>>> +  - support HugeTLB page migration and offlining.
>>
>> ... I remember that Oscar was doing something in that area, Oscar?
> 
> Yes, in general offlinining on hugetlb pages was already working, but we did not
> allow to offline 1GB-hugetlb pages on x86_64.
> I removed that limitation with
> ("commit: 10eeadf3045c mm,memory_hotplug: unlock 1GB-hugetlb on x86_64") , so now
> offlining on hugetlb pages should be fully operative.
> 
>> I'd vote for removing the future work part, this is pretty outdated.
> 
> Instead of removing it, I would rather make it consistent with the present.
> E.g:
> 
> - Move page handling from memory-hotremove to offline stage
> - Enable a way to allocate vmemmap pages from hot-added memory
> etc.
> 
> 

Fair enough, but at least the current content is absolutely useless and
confusing/misleading.

-- 

Thanks,

David / dhildenb