linux-kernel - Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dcb1f2d8-5894-ee7a-6413-ad6f596da888@canonical.com>
Date:   Wed, 22 May 2019 11:00:04 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with
 less than zero

On 22/05/2019 10:53, Dan Carpenter wrote:
> No.  This isn't the right fix.  We should declare them as int instead.

Doh, brown paper bag time. I'll do a V2.

> 
> regards,
> dan carpenter
>