lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 22 May 2019 11:41:03 +0100
From:   Catalin Marinas <>
To:     Andrey Konovalov <>
        Vincenzo Frascino <>,
        Will Deacon <>,
        Mark Rutland <>,
        Andrew Morton <>,
        Greg Kroah-Hartman <>,
        Kees Cook <>,
        Yishai Hadas <>,
        Felix Kuehling <>,
        Alexander Deucher <>,
        Christian Koenig <>,
        Mauro Carvalho Chehab <>,
        Jens Wiklander <>,
        Alex Williamson <>,
        Leon Romanovsky <>,
        Dmitry Vyukov <>,
        Kostya Serebryany <>,
        Evgeniy Stepanov <>,
        Lee Smith <>,
        Ramana Radhakrishnan <>,
        Jacob Bramley <>,
        Ruben Ayrapetyan <>,
        Robin Murphy <>,
        Luc Van Oostenryck <>,
        Dave Martin <>,
        Kevin Brodsky <>,
        Szabolcs Nagy <>
Subject: Re: [PATCH v15 03/17] lib, arm64: untag user pointers in strn*_user

On Mon, May 06, 2019 at 06:30:49PM +0200, Andrey Konovalov wrote:
> This patch is a part of a series that extends arm64 kernel ABI to allow to
> pass tagged user pointers (with the top byte set to something else other
> than 0x00) as syscall arguments.
> strncpy_from_user and strnlen_user accept user addresses as arguments, and
> do not go through the same path as copy_from_user and others, so here we
> need to handle the case of tagged user addresses separately.
> Untag user pointers passed to these functions.
> Note, that this patch only temporarily untags the pointers to perform
> validity checks, but then uses them as is to perform user memory accesses.
> Signed-off-by: Andrey Konovalov <>

Just to keep track of where I am with the reviews while the ABI
discussion continues:

Reviewed-by: Catalin Marinas <>

Powered by blists - more mailing lists