linux-kernel - Re: [PATCH v5 2/5] USB: use genalloc for USB HCs with local memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 May 2019 10:54:02 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Fredrik Noring <noring@...rew.org>
CC:     "hch@....de" <hch@....de>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "marex@...x.de" <marex@...x.de>, Leo Li <leoyang.li@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "JuergenUrban@....de" <JuergenUrban@....de>
Subject: Re: [PATCH v5 2/5] USB: use genalloc for USB HCs with local memory


On 21.05.2019 18:27, Fredrik Noring wrote:
> Thanks Laurentiu!
> 
>> --- a/include/linux/usb/hcd.h
>> +++ b/include/linux/usb/hcd.h
>> @@ -216,6 +216,9 @@ struct usb_hcd {
>>   #define	HC_IS_RUNNING(state) ((state) & __ACTIVE)
>>   #define	HC_IS_SUSPENDED(state) ((state) & __SUSPEND)
>>   
>> +	/* allocator for HCs having local memory */
>> +	struct gen_pool         *localmem_pool;
>> +
> 
> I have tested patches 1, 2 and 5, and they seem to work. Nice! 

Great! Thanks for testing. I'll add your Tested-By tags on the patches 
you mentioned.

> May I suggest clarifying the NULL pointers? I think that may help someone
> debugging or maintaining this in the future. Something like this:

Sure, will include in v6.

---
Best Regards, Laurentiu