linux-kernel - Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0581341-126a-5733-3c4b-8e6f67bfc32e@linaro.org>
Date:   Wed, 22 May 2019 14:30:16 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Heiko Stuebner <heiko@...ech.de>,
        Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Elaine Zhang <zhangqing@...k-chips.com>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        huangtao@...k-chips.com, Linux PM list <linux-pm@...r.kernel.org>,
        xxx@...k-chips.com, xf@...k-chips.com,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Eduardo Valentin <edubezval@...il.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Doug Anderson <dianders@...omium.org>, vicencb@...il.com
Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl
 setting error

On 22/05/2019 14:27, Heiko Stuebner wrote:

[ ... ]

>> As this change is now in mainline and is causing veyron to hang I'd
>> suggest reverting this change for now. Even fixing the root cause
>> (maybe the one I pointed above) after this patch we will have the
>> thermal driver to fail because "gpio" and "otpout" states are not
>> defined nor documented (a change on this will need some reviews and
>> acks and time I guess).
> 
> I definitly agree here. Handling + checking the binding change
> as well as needed fallback code is definitly not material for -rc-kernels
> so we should just revert for now and let Elaine fix the issues for 5.3.
> 
> Anyone volunteering for sending a revert-patch to Eduardo? :-)

I can't right now :/


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog