linux-kernel - Re: [PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuJOoQVp4xPi+Y4fVqCThVUypv+NEOi+kdvWGoz0c30fEg@mail.gmail.com>
Date:   Wed, 22 May 2019 10:08:25 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:     Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init_mmio()

On Wed, 22 May 2019 at 09:15, Chunyan Zhang <zhang.chunyan@...aro.org> wrote:
>
> The function devm_regmap_init_mmio() wouldn't return NULL pointer for
> now, so only need to ensure the return value is not an error code.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@...aro.org>

Reviewed-by: Baolin Wang <baolin.wang@...aro.org>

> ---
>  drivers/clk/sprd/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> index 9ce690999eaa..a5bdca1de5d0 100644
> --- a/drivers/clk/sprd/common.c
> +++ b/drivers/clk/sprd/common.c
> @@ -58,7 +58,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
>
>                 regmap = devm_regmap_init_mmio(&pdev->dev, base,
>                                                &sprdclk_regmap_config);
> -               if (IS_ERR_OR_NULL(regmap)) {
> +               if (IS_ERR(regmap)) {
>                         pr_err("failed to init regmap\n");
>                         return PTR_ERR(regmap);
>                 }
> --
> 2.17.1
>


-- 
Baolin Wang
Best Regards