linux-kernel - Re: [PATCH] crypto: arm/sha512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190523053849.u2rpdk5ddafrkcnx@gondor.apana.org.au>
Date:   Thu, 23 May 2019 13:38:49 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Philippe Mazenauer <philippe.mazenauer@...look.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        "open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
        "moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: arm/sha512 - make function static

On Wed, May 22, 2019 at 10:07:14AM +0000, Philippe Mazenauer wrote:
> Function sha512_arm_final() is only used in this file, therefore should
> be static
> 
> ../arch/arm/crypto/sha512-glue.c:40:5: warning: no previous prototype for ‘sha512_arm_final’ [-Wmissing-prototypes]
>  int sha512_arm_final(struct shash_desc *desc, u8 *out)
>      ^~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@...look.de>

An identical patch is already in the patchwork queue.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt