linux-kernel - Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiUnRSSPLDhXeAg5E0pM_-ZbNV9qpOarSemDdpwLPRZeqA@mail.gmail.com>
Date:   Thu, 23 May 2019 16:23:13 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

On Thu, May 23, 2019 at 4:00 PM Joe Perches <joe@...ches.com> wrote:
> patch 2/2 specifically covers the anybuss directory,
> but the Documentation directory has no matching pattern.

Thank you for spotting that, I will re-spin the set.

>
> trivia: anybuss looks like a misspelling.
> It might be better as anybus-s.
>

This came up as well during the review process. When we insert a separator,
the include files start looking like anybus-s-controller.h, and the structs
become like struct anybus_s_ops. It then no longer looks like a misspelling,
but becomes harder to read?

An alternative solution is to get rid of the 's' suffix altogether. Anybus-S
is the only flavour we support right now. Although that may obviously
change in the future.