linux-kernel - Re: [PATCH] arm64: dts: allwinner: a64-oceanic-5205-5inmfd: Enable CAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190523205450.bwccpvehpiugogbs@flea>
Date:   Thu, 23 May 2019 22:54:50 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Michael Nazzareno Trimarchi <michael@...rulasolutions.com>
Cc:     Jagan Teki <jagan@...rulasolutions.com>,
        Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-amarula <linux-amarula@...rulasolutions.com>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH] arm64: dts: allwinner: a64-oceanic-5205-5inmfd: Enable
 CAN

Hi Michael,

On Tue, May 21, 2019 at 01:08:09PM +0200, Michael Nazzareno Trimarchi wrote:
> On Tue, May 21, 2019 at 10:10 AM Maxime Ripard
> <maxime.ripard@...tlin.com> wrote:
> >
> > On Tue, May 21, 2019 at 08:47:02AM +0200, Michael Nazzareno Trimarchi wrote:
> > > > > +     };
> > > > > +
> > > > >  };
> > > > >
> > > > >  &ehci0 {
> > > > > @@ -77,6 +95,31 @@
> > > > >       status = "okay";
> > > > >  };
> > > > >
> > > > > +&pio {
> > > > > +     can_pins: can-pins {
> > > > > +             pins = "PD6",                   /* RX_BUF1_CAN0 */
> > > > > +                    "PD7";                   /* RX_BUF0_CAN0 */
> > > > > +             function = "gpio_in";
> > > > > +     };
> > > > > +};
> > > >
> > > > That isn't needed. What are they used for, you're not tying them to
> > > > anything?
> > >
> > > Mux of their function is correct. They are connected in the schematics
> > > but not used right now.
> >
> > Then describe the whole thing or don't?
> >
>
> Ok
>
> > And that's kind of missing my point. If that pin group isn't related
> > to any device, the pin muxing will not be changed. So that group, in
> > itself, has strictly no effect.
> >
> > Moreover, you don't need a pin group in the first place to mux pins in
> > GPIOs, the GPIO API will make sure that is the case when you request
> > it.
>
> This is correct on sunxi. Is this valid for sunxi or in general in
> all the SoC?

IIRC, it happens on all the SoCs that have a shared GPIO/pinctrl
driver.

> Anyway make sense to have pins configured and place in the right
> state, just suppose if the booting stage is wrong or anything that
> make those pins in the wrong configuration

It would be a bug in the pinctrl / GPIO code that would need to be
fixed.

> >
> > > I can garantee that kernel wlll always configurred in the right way
> > > and if I want I can export in userspace
> > > for debug purpose
>
> Correct if you start to use it but if you want them right configured
> the right place is in the default state e/o initstate if this can be
> a problem of the hardware

What problem do you have exactly?

> Default state: the state the pinctrl handle shall be put
>  *      into as default, usually this means the pins are up and ready to
>  *      be used by the device driver. This state is commonly used by
>  *      hogs to configure muxing and pins at boot, and also as a state
>  *      to go into when returning from sleep and idle in
>  *      .pm_runtime_resume() or ordinary .resume() for example.
>
> Now the pins are connected to the canbus as should be and they are
> configured and usually put in the right state.

As soon as you call gpio_get, the pins will be configured properly.

And, pinctrl shouldn't allow that configuration (gpio_get + a pinctrl
node for GPIOs) in our case. We do on most SoCs (all but the H6) for
historical reasons, but this creates other bugs that we can't really
fix right now. Still, we're slowly removing all of those pinctrl
nodes, so it's not really to add new ones.

> +               compatible = "microchip,mcp2515";
> +               reg = <0>;
> +               spi-max-frequency = <10000000>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&can_pins>;
>
> >
> > Yes, because the API does it, not your change
>
> Do you prefer to drop the pinmux? or update the commit message

Drop the pinctrl group

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com