[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190523220610.GB15523@amd>
Date: Fri, 24 May 2019 00:06:10 +0200
From: Pavel Machek <pavel@....cz>
To: Angus Ainslie <angus@...ea.ca>
Cc: angus.ainslie@...i.sm, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-kernel-owner@...r.kernel.org
Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for
the Librem5 devkit
Hi!
> >>This is for the development kit board for the Librem 5. The current
> >>level
> >>of support yields a working console and is able to boot userspace from
> >>the network or eMMC.
> >>
> >>Additional subsystems that are active :
> >
> >>- haptic motor
> >
> >Haptic motor is not a LED. It should be controlled by input subsystem.
> >
> >>+ pwmleds {
> >>+ compatible = "pwm-leds";
> >>+
> >>+ haptic {
> >>+ label = "librem5::haptic";
> >>+ pwms = <&pwm2 0 200000>;
> >>+ active-low;
> >>+ max-brightness = <255>;
> >>+ power-supply = <®_3v3_p>;
> >>+ };
> >>+ };
> >
> >You can take a look at N900, that has reasonable interface.
>
> I wanted to control the haptic with the pwm-vibra driver but "fsl,imx27-pwm"
> doesn't seem to respect the PWM_POLARITY_INVERTED flag so when I start the
> system the vibrator is full on.
Ok, lets fix that :-).
> I could use gpio-vibrator but that seemed like a waste when the device is
> connected to pwm.
>
> I figured the using the pwm-leds interface was a reasonable compromise until
> I had an opportunity to make changes the the imx27-pwm driver.
I guess in such case it would be best to leave out this section for
now... or keep it disabled / something. We don't want incorrect device
trees to stick around.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists