linux-kernel - Re: [PATCH] powerpc/32s: Include <linux/moduleloader.h> header file to fix a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14b3a3c9-acbd-67b4-9187-912bb1be887f@c-s.fr>
Date:   Thu, 23 May 2019 08:54:14 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Mathieu Malaterre <malat@...ian.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     Paul Mackerras <paulus@...ba.org>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/32s: Include <linux/moduleloader.h> header file
 to fix a warning



Le 23/05/2019 à 08:49, Mathieu Malaterre a écrit :
> In commit 2edb16efc899 ("powerpc/32: Add KASAN support") support for
> KASAN has been added. However building it as module leads to (warning
> treated as error with W=1):
> 
>    arch/powerpc/mm/kasan/kasan_init_32.c:135:7: error: no previous prototype for 'module_alloc' [-Werror=missing-prototypes]
> 
> Make sure to include <linux/moduleloader.h> to provide the following
> prototype: module_alloc.
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Fixes: 2edb16efc899 ("powerpc/32: Add KASAN support")
Reviewed-by: Christophe Leroy <christophe.leroy@....fr>

> ---
>   arch/powerpc/mm/kasan/kasan_init_32.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c
> index 0d62be3cba47..0c31e440d094 100644
> --- a/arch/powerpc/mm/kasan/kasan_init_32.c
> +++ b/arch/powerpc/mm/kasan/kasan_init_32.c
> @@ -7,6 +7,7 @@
>   #include <linux/memblock.h>
>   #include <linux/sched/task.h>
>   #include <linux/vmalloc.h>
> +#include <linux/moduleloader.h>
>   #include <asm/pgalloc.h>
>   #include <asm/code-patching.h>
>   #include <mm/mmu_decl.h>
>