linux-kernel - Re: [PATCH 1/6] staging: kpc2000: fix indent in cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 May 2019 09:27:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Simon Sandström <simon@...anor.nu>
Cc:     jeremy@...zel.net, dan.carpenter@...cle.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

On Thu, May 23, 2019 at 09:26:25AM +0200, Greg KH wrote:
> On Wed, May 22, 2019 at 10:58:44PM +0200, Simon Sandström wrote:
> > Use tabs instead of spaces for indentation.
> > 
> > Signed-off-by: Simon Sandström <simon@...anor.nu>
> > ---
> >  drivers/staging/kpc2000/kpc2000/cell_probe.c | 574 +++++++++----------
> >  1 file changed, 287 insertions(+), 287 deletions(-)
> > 
> > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > index 0181b0a8ff82..6e034d115b47 100644
> > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > @@ -25,7 +25,7 @@
> >   *                                                              D                   C2S DMA Present
> >   *                                                               DDD                C2S DMA Channel Number    [up to 8 channels]
> >   *                                                                  II              IRQ Count [0 to 3 IRQs per core]
> > -                                                                      1111111000
> > + *                                                                    1111111000
> >   *                                                                    IIIIIII       IRQ Base Number [up to 128 IRQs per card]
> >   *                                                                           ___    Spare
> >   *
> 
> This chunk does not match what you said this commit did :(
> 
> Please fix up and resend.

Actually, wait, rebase and resend after I apply your other patches.
I'll hand-edit this patch to remove this chunk as your other fixes are
good...

thanks,

greg k-h