linux-kernel - Re: [PATCH] powerpc/powernv: fix variable "c" set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190523074654.GA9873@infradead.org>
Date:   Thu, 23 May 2019 00:46:54 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Christophe Leroy <christophe.leroy@....fr>
Cc:     Qian Cai <cai@....pw>, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, aik@...abs.ru, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/powernv: fix variable "c" set but not used

On Thu, May 23, 2019 at 09:26:53AM +0200, Christophe Leroy wrote:
> You are not fixing the problem, you are just hiding it.
> 
> If the result of __get_user() is unneeded, it means __get_user() is not the
> good function to use.
> 
> Should use fault_in_pages_readable() instead.

Also it is not just the variable that is unused, but that whole
function.  I'll resend my series to remote it in a bit.