linux-kernel - Re: [PATCH] staging: fieldbus: anybuss: Remove variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190523084318.GB831@kroah.com>
Date:   Thu, 23 May 2019 10:43:18 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nishka Dasgupta <nishka.dasgupta@...oo.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fieldbus: anybuss: Remove variable

On Thu, May 23, 2019 at 01:52:29PM +0530, Nishka Dasgupta wrote:
> 
> 
> On 23/05/19 12:52 PM, Greg KH wrote:
> > On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote:
> > > Variable client, assigned to priv->client, is used only once in a
> > > function argument; hence, it can be removed and the function argument
> > > replaced with priv->client directly.
> > > Issue found with Coccinelle.
> > > 
> > > Signed-off-by: Nishka Dasgupta <nishka.dasgupta@...oo.com>
> > > ---
> > >   drivers/staging/fieldbus/anybuss/hms-profinet.c | 4 +---
> > >   1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/fieldbus/anybuss/hms-profinet.c b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > index 5446843e35f4..a7f85912fa92 100644
> > > --- a/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > +++ b/drivers/staging/fieldbus/anybuss/hms-profinet.c
> > > @@ -124,9 +124,7 @@ static int __profi_enable(struct profi_priv *priv)
> > >   static int __profi_disable(struct profi_priv *priv)
> > >   {
> > > -	struct anybuss_client *client = priv->client;
> > > -
> > > -	anybuss_set_power(client, false);
> > > +	anybuss_set_power(priv->client, false);
> > 
> > Same comments are relevant here as the last patch you sent.
> 
> So just to clarify this patch isn't necessary and I should cc Sven?

For future patches to any drivers/staging/fieldbus/ changes, yes.

thanks,

greg k-h