linux-kernel - Re: [PATCH v2] KVM: selftests: Compile code with warnings enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 May 2019 11:11:33 +0200
From:   Andrew Jones <drjones@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Thomas Huth <thuth@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        linux-kselftest@...r.kernel.org, kvm@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>, Peter Xu <peterx@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: selftests: Compile code with warnings enabled

On Mon, May 20, 2019 at 12:03:08PM +0200, Paolo Bonzini wrote:
> On 17/05/19 11:04, Thomas Huth wrote:
> > So far the KVM selftests are compiled without any compiler warnings
> > enabled. That's quite bad, since we miss a lot of possible bugs this
> > way. Let's enable at least "-Wall" and some other useful warning flags
> > now, and fix at least the trivial problems in the code (like unused
> > variables).
> > 
> > Signed-off-by: Thomas Huth <thuth@...hat.com>
> > ---
> >  v2:
> >  - Rebased to kvm/queue
> >  - Fix warnings in state_test.c and evmcs_test.c, too
> > 
> >  tools/testing/selftests/kvm/Makefile                       | 4 +++-
> >  tools/testing/selftests/kvm/dirty_log_test.c               | 6 +++++-
> >  tools/testing/selftests/kvm/lib/kvm_util.c                 | 3 ---
> >  tools/testing/selftests/kvm/lib/x86_64/processor.c         | 4 +---
> >  tools/testing/selftests/kvm/x86_64/cr4_cpuid_sync_test.c   | 1 +
> >  tools/testing/selftests/kvm/x86_64/evmcs_test.c            | 7 +------
> >  tools/testing/selftests/kvm/x86_64/platform_info_test.c    | 1 -
> >  tools/testing/selftests/kvm/x86_64/smm_test.c              | 3 +--
> >  tools/testing/selftests/kvm/x86_64/state_test.c            | 7 +------
> >  .../selftests/kvm/x86_64/vmx_close_while_nested_test.c     | 5 +----
> >  tools/testing/selftests/kvm/x86_64/vmx_tsc_adjust_test.c   | 5 ++---
> >  11 files changed, 16 insertions(+), 30 deletions(-)
> 
> Queued, with a squashed fix to kvm_get_supported_hv_cpuid.
>

I've done the fixups needed to keep aarch64 compiling and will send
the patch shortly.

drew