linux-kernel - Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0402MB3476BE4FE08AC135742D262998010@AM0PR0402MB3476.eurprd04.prod.outlook.com>
Date:   Thu, 23 May 2019 10:02:41 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@....com>
CC:     Aymen Sghaier <aymen.sghaier@....com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256)
 failure because of invalid input

On 5/23/2019 9:12 AM, Herbert Xu wrote:
> On Wed, May 15, 2019 at 02:25:45PM +0300, Iuliana Prodan wrote:
>>
>> @@ -1058,6 +1105,14 @@ static int __init caam_pkc_init(void)
>>  		goto out_put_dev;
>>  	}
>>  
>> +	/* allocate zero buffer, used for padding input */
>> +	zero_buffer = kzalloc(CAAM_RSA_MAX_INPUT_SIZE - 1, GFP_DMA |
>> +			      GFP_KERNEL);
>> +	if (!zero_buffer) {
>> +		err = -ENOMEM;
>> +		goto out_put_dev;
>> +	}
>> +
>>  	err = crypto_register_akcipher(&caam_rsa);
>>  	if (err)
>>  		dev_warn(ctrldev, "%s alg registration failed\n",
> 
> This patch does not apply on top of the caam patch-series from Horia.
The patch was considered a fix, and thus developed on top of crypto-2.6.
I guess you are implicitly asking to resubmit based on cryptodev-2.6, correct?

> You're also going to leak zero_buffer if crypto_register_akcipher
> fails.
> 
When crypto_register_akcipher fails, it merely prints a warning and falls
through (does not immediately return), thus there's no leak.

Thanks,
Horia